NobiGo commented on code in PR #4214:
URL: https://github.com/apache/calcite/pull/4214#discussion_r2025834254
##########
core/src/main/java/org/apache/calcite/rel/rel2sql/SqlImplementor.java:
##########
@@ -855,6 +855,76 @@ private SqlNode callToSql(@Nullable RexProgram program,
RexCall call0,
final RexCall call = (RexCall) stripCastFromString(call1, dialect);
SqlOperator op = call.getOperator();
switch (op.getKind()) {
+ case IS_FALSE:
Review Comment:
I have also been pondering over this for a long time. How can I accurately
express it so that the developers can quickly figure out which functions should
be added here and which ones should use unparseCall instead?
How about `unparseCallPartial` The meaning is that this function "unparse"
is supported in certain scenarios, not in all cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
