nielspardon commented on PR #4239: URL: https://github.com/apache/calcite/pull/4239#issuecomment-2796016662
> > `RelRoot.isNameTrivial()` was unused until your change. Now it is used it needs javadoc, with some useful examples. Can you also add javadoc for `isRefTrivial`, `isCollationTrivial`. > > Done, I added javadocs to the methods. I added examples for `isNameTrivial()` and `isRefTrivial()`. For `isCollationTrivial()` I couldn't think of a good example. Let me know if you have one I should add. @julianhyde I haven't heard back from you in a month. anything else I can do on this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
