xiedeyantu commented on PR #4312:
URL: https://github.com/apache/calcite/pull/4312#issuecomment-2811477616
> Have you reviewed the DiffRepository test method? Can we improve this
method? Currently, any new files that need testing must be added manually.
I reviewed this and noticed that it also requires explicit class name, such
as:
```
@Override RelOptFixture fixture() {
RelOptFixture fixture = super.fixture()
.withDiffRepos(DiffRepository.lookup(RelOptRulesTest.class));
diffRepos = fixture.diffRepos();
return fixture;
}
```
Additionally, I have a concern. Currently, all XML files are located under
`core/src/test/resources/org/apache/calcite/test/`, alongside `.csv` files.
Would it be appropriate for me to scan all XML files under this path
programmatically, or should we keep explicitly specifying the files?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
