xuzifu666 commented on code in PR #4323:
URL: https://github.com/apache/calcite/pull/4323#discussion_r2055491653
##########
core/src/main/java/org/apache/calcite/sql/dialect/MysqlSqlDialect.java:
##########
@@ -71,10 +71,22 @@ public class MysqlSqlDialect extends SqlDialect {
return 65535;
case TIMESTAMP:
return 6;
+ case DECIMAL:
+ return 65;
default:
return super.getMaxPrecision(typeName);
}
}
+
+ @Override public int getMaxScale(SqlTypeName typeName) {
Review Comment:
Done，had add document links of MySQL 5.x and 8.x(which are the most used
version), thanks for the suggestion. @mihaibudiu
##########
core/src/main/java/org/apache/calcite/sql/dialect/MysqlSqlDialect.java:
##########
@@ -71,10 +71,22 @@ public class MysqlSqlDialect extends SqlDialect {
return 65535;
case TIMESTAMP:
return 6;
+ case DECIMAL:
+ return 65;
default:
return super.getMaxPrecision(typeName);
}
}
+
+ @Override public int getMaxScale(SqlTypeName typeName) {
Review Comment:
Done，had added document links of MySQL 5.x and 8.x(which are the most used
version), thanks for the suggestion. @mihaibudiu
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
