suibianwanwank opened a new pull request, #4332:
URL: https://github.com/apache/calcite/pull/4332
Link: [CALCITE-6962]
When converting Correlate to Join, we should use null_equal join (i.e., `is
not distinct from`).
Fixing this is straightforward - we just need to change:
```
conditions.add(
relBuilder.equals(RexInputRef.of(newLeftPos, newLeftOutput),
new RexInputRef(newLeftFieldCount + newRightPos,
newRightOutput.get(newRightPos).getType())));
```
to `is not distinct from`.
However, this will impact a large number of tests and even downstream
applications (on engines that support null-equal joins, I believe this won't
cause any performance difference).
The core modification involved using `equal` to non-nullable column.
However, this change still led to several test modifications, partly due to the
current approach's incomplete handling of certain cases.
Before fully fixing these tests, I'd appreciate any suggestions. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
