mihaibudiu commented on code in PR #4331:
URL: https://github.com/apache/calcite/pull/4331#discussion_r2067514009
##########
core/src/main/java/org/apache/calcite/rel/rel2sql/SqlImplementor.java:
##########
@@ -350,6 +350,16 @@ public static SqlNode convertConditionToSqlNode(RexNode
node,
*/
private static RexNode stripCastFromString(RexNode node, SqlDialect dialect)
{
switch (node.getKind()) {
+ case IS_NULL:
Review Comment:
Are you saying that in Presto there is no explicit cast from VARCHAR to a
numeric type?
I think that only the dialect can decide which cast to strip.
I don't think this logic can be in SqlImplementor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
