mihaibudiu commented on code in PR #4353:
URL: https://github.com/apache/calcite/pull/4353#discussion_r2071920048
##########
core/src/main/java/org/apache/calcite/sql/validate/implicit/TypeCoercionImpl.java:
##########
@@ -383,12 +383,16 @@ protected boolean booleanEquality(SqlCallBinding binding,
return false;
}
+ @Deprecated @Override public boolean caseWhenCoercion(SqlCallBinding
callBinding) {
+ return caseOrEquivalentCoercion(callBinding);
+ }
+
/**
* CASE WHEN and COALESCE type coercion, collect all the branches types
including then
* operands and else operands to find a common type, then cast the operands
to the common type
* when needed.
*/
- @Override public boolean caseWhenCoercion(SqlCallBinding callBinding) {
+ @Override public boolean caseOrEquivalentCoercion(SqlCallBinding
callBinding) {
Review Comment:
from your description it seems that NULLIF is wrong too: the arguments
should be coerced and then the type of ARG0 is correct.
can you also please add a test case for NULLIF?
If we are changing the API to handle all CASE-equivalents, we need to handle
all equivalent operations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
