NobiGo commented on code in PR #4384:
URL: https://github.com/apache/calcite/pull/4384#discussion_r2096735210
##########
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##########
@@ -12487,6 +12487,29 @@ private static void
checkStringAggFuncFails(SqlOperatorFixture f) {
false);
}
+ /** Test case for
+ * <a
href="https://issues.apache.org/jira/browse/CALCITE-6951";>[CALCITE-6951]
+ * Add STRING_TO_ARRAY function(enabled in PostgreSQL Library)</a>.
Review Comment:
Should be `</a>. */`,No need for a line break. Please note to add space
after `</a>.`.
##########
site/_docs/reference.md:
##########
@@ -2945,6 +2945,7 @@ In the following:
| s | MAP_FROM_ENTRIES(arrayOfRows) | Returns a map created
from an arrays of row with two fields. Note that the number of fields in a row
must be 2. Note that calcite is using the LAST_WIN strategy
| s | STR_TO_MAP(string [, stringDelimiter [, keyValueDelimiter]]) | Returns a
map after splitting the *string* into key/value pairs using delimiters. Default
delimiters are ',' for *stringDelimiter* and ':' for *keyValueDelimiter*. Note
that calcite is using the LAST_WIN strategy
| s | SUBSTRING_INDEX(string, delim, count) | Returns the substring
from *string* before *count* occurrences of the delimiter *delim*. If *count*
is positive, everything to the left of the final delimiter (counting from the
left) is returned. If *count* is negative, everything to the right of the final
delimiter (counting from the right) is returned. The function substring_index
performs a case-sensitive match when searching for *delim*.
+| p r | STRING_TO_ARRAY(string, delimiter [, nullText ]) | Returns a
one-dimensional text[] array by splitting the input text value into subvalues
using the specified text value as the "delimiter". Optionally, allows a
specified text value to be interpreted as NULL.
Review Comment:
Replace text with String? There is no "text" data type in Calcite.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
