suibianwanwank commented on code in PR #4382:
URL: https://github.com/apache/calcite/pull/4382#discussion_r2108561848


##########
core/src/main/java/org/apache/calcite/rex/RexUtil.java:
##########
@@ -1867,6 +1869,29 @@ public static RexNode shift(RexNode node, final int 
start, final int offset) {
         });
   }
 
+  /**
+   * Shifts every {@link RexFieldAccess} with {@link CorrelationId}
+   * in an {@link RelNode} by {@code offset}.
+   */
+  public static RelNode shiftFieldAccess(RexBuilder rexBuilder, RelNode node,
+      final CorrelationId id, RelNode outer, final int offset) {

Review Comment:
   The construction of CorrelationId is public, and the Id type is int. We 
cannot assume users won't use negative numbers. Therefore, I don't recommend 
implementing validation here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to