asolimando commented on PR #4392: URL: https://github.com/apache/calcite/pull/4392#issuecomment-2915778540
> > I haven't really checked that the algorithm is correctly implemented, I left only comments about the code structure. I think this needs way more tests, even if they are slow tests. You need for example to test on plans with lots of joins and check that all the orders generated are valid and generate the same result, even if they are not optimal. This will exercise the code much more deeply than the tests you have now. > > Thank you very much for your detailed review. I have replied to some comments and hope to discuss further with you. I will update the relevant code for the other comments that I have not replied to. > > In addition, when you say more tests, you mean that I should add some test cases in `RelOptRulesTest`, which have many tables involved in join graph, although the enumeration process may be slow in this case. Am I understanding it correctly? If they are slow, these extra tests can be marked as "slow tests" and they won't be run all the time in CI (only when the "slow test" label is present). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
