NobiGo commented on code in PR #4404:
URL: https://github.com/apache/calcite/pull/4404#discussion_r2137335699
##########
core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableLimitSortRule.java:
##########
@@ -57,7 +57,7 @@ public interface Config extends RelRule.Config {
ImmutableEnumerableLimitSortRule.Config.of()
.withOperandSupplier(b0 ->
b0.operand(LogicalSort.class)
- .predicate(sort -> sort.fetch != null)
+ .predicate(sort -> sort.fetch != null &&
!sort.getSortExps().isEmpty())
Review Comment:
The offset should not be ignore here, according to my understanding, there
should also be a lack of corresponding test cases here. `sort.getSortExps()`
should be replaced with `sort.collation.getFieldCollations()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
