mihaibudiu commented on code in PR #4388:
URL: https://github.com/apache/calcite/pull/4388#discussion_r2157662451


##########
core/src/test/java/org/apache/calcite/test/SqlValidatorTest.java:
##########
@@ -8782,6 +8782,12 @@ void testGroupExpressionEquivalenceParams() {
     sql("select stream * from orders left join products_temporal\n"
         + "for system_time as of CURRENT_TIMESTAMP\n"
         + "on orders.productid = products_temporal.productid").ok();
+
+    // verify left join of CTEs

Review Comment:
   One way this can be resolved is to have a conformance flag 
(systemTimeForQueries?) which makes this query legal, and then disable this 
check only if that conformance flag is enabled. Supposedly compiling for Flink 
would enable it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to