mihaibudiu commented on code in PR #4439:
URL: https://github.com/apache/calcite/pull/4439#discussion_r2167291378
##########
core/src/main/java/org/apache/calcite/sql/validate/implicit/AbstractTypeCoercion.java:
##########
@@ -213,7 +214,11 @@ protected boolean coerceColumnType(
}
RelDataType targetType3 = syncAttributes(validator.deriveType(scope,
node), targetType);
SqlNode node3 = castTo(node, targetType3);
- if (node.getKind() == SqlKind.IDENTIFIER) {
+ // Although this function is called coerceColumnType, it is not always
invoked on a "column".
Review Comment:
"column" is with respect to the produced row. The expression is not always a
column in the resulting row.
But I see how the comment can be misinterpreted, I will clarify.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
