xuzifu666 commented on code in PR #4441:
URL: https://github.com/apache/calcite/pull/4441#discussion_r2173737800
##########
elasticsearch/src/main/java/org/apache/calcite/adapter/elasticsearch/ElasticsearchJson.java:
##########
@@ -109,9 +110,10 @@ static void visitMappingProperties(ObjectNode mapping,
BiConsumer<String, String> consumer) {
requireNonNull(mapping, "mapping");
requireNonNull(consumer, "consumer");
- if (mapping.has("properties")) {
- visitMappingProperties(new ArrayDeque<>(), mapping, consumer);
+ if (mapping.findPath("properties") instanceof MissingNode) {
Review Comment:
I am not particularly clear about the logic of this, but I saw that there is
a issue(https://issues.apache.org/jira/browse/CALCITE-3190) in the history that
has not been closed . it seems that a method in the tool class does not
correctly extract the "properties" attribute. The relevant
PR(https://github.com/apache/calcite/pull/1313) has been reviewed with many
comments before, so it should have potential value IMO. @NobiGo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
