NobiGo commented on code in PR #4456:
URL: https://github.com/apache/calcite/pull/4456#discussion_r2181386682
##########
core/src/main/java/org/apache/calcite/rel/rel2sql/SqlImplementor.java:
##########
@@ -182,10 +183,17 @@ protected SqlImplementor(SqlDialect dialect) {
/** Visits a relational expression that has no parent. */
public final Result visitRoot(RelNode r) {
RelNode best;
- if (!this.dialect.supportsGroupByLiteral()) {
+ if (!this.dialect.supportsGroupByLiteral()
Review Comment:
I originally planned to directly convert the Join into an SqlNode in the
RelToSqlConverter. This approach seemed quite reasonable now.
##########
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java:
##########
@@ -10136,6 +10136,55 @@ private void checkLiteral2(String expression, String
expected) {
sql(sql).ok(expected);
}
+ /** Test case for
+ * <a
href="https://issues.apache.org/jira/browse/CALCITE-7050";>[CALCITE-7050]
+ * Invalid unparse for FULL JOIN in MySQLDialect</a>. */
+ @Test void testUnsupportedFullJoin() {
+ // MySQL full join would transform to left join union right join
+ String sql = "select *\n"
Review Comment:
Select the specific columns will make this test case clearer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
