xuzifu666 commented on code in PR #4458:
URL: https://github.com/apache/calcite/pull/4458#discussion_r2184844029
##########
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java:
##########
@@ -5032,15 +5032,16 @@ private SqlDialect nonOrdinalDialect() {
*/
@Test void testCastAsMapType() {
sql("SELECT CAST(MAP['A', 1.0] AS MAP<VARCHAR, DOUBLE>)")
- .ok("SELECT CAST(MAP['A', 1.0] AS MAP< VARCHAR CHARACTER SET
\"ISO-8859-1\", DOUBLE >)\n"
+ .ok("SELECT CAST(MAP['A', 1.0] AS "
Review Comment:
Due to you changed deriveType method, maybe we also need to add a test for
nested Map， such as Map<VARCHAR, MAP<VARCHAR, VARCHAR>> case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
