xuzifu666 commented on code in PR #4460:
URL: https://github.com/apache/calcite/pull/4460#discussion_r2191302824
##########
core/src/test/java/org/apache/calcite/rex/RexProgramTest.java:
##########
@@ -3952,9 +3954,13 @@ private void checkSarg(String message, Sarg sarg,
"OR(IS NOT NULL($0), LIKE($0, '% %'))", "true");
checkSimplify(or(isNull(ref), like(ref, literal("%"))),
"true");
+ checkSimplify(or(isNull(ref), like(ref, literal("%%"))),
+ "true");
checkSimplify(or(isNull(ref), like(ref, literal("%"), literal("#"))),
"true");
checkSimplifyUnchanged(like(ref, literal("%A")));
+ checkSimplifyUnchanged(like(ref, literal("%%A")));
Review Comment:
You are right, here also need to be simplified.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
