mihaibudiu commented on code in PR #4481:
URL: https://github.com/apache/calcite/pull/4481#discussion_r2237951754
##########
core/src/main/java/org/apache/calcite/rel/rel2sql/SqlImplementor.java:
##########
@@ -1897,7 +1897,7 @@ private Builder builder(RelNode rel, Set<Clause> clauses)
{
if (!selectList.equals(SqlNodeList.SINGLETON_STAR)) {
final boolean aliasRef = expectedClauses.contains(Clause.HAVING)
&& dialect.getConformance().isHavingAlias();
- newContext = new Context(dialect, selectList.size()) {
+ newContext = new BaseContext(dialect, selectList.size()) {
Review Comment:
I think this class is big enough to be pulled outside in a static named
class.
(The original author should have done that, and documented what this class
is supposed to do)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
