bchapuis commented on code in PR #3668:
URL: https://github.com/apache/calcite/pull/3668#discussion_r2244430654
##########
core/src/main/java/org/apache/calcite/sql/type/SqlTypeAssignmentRule.java:
##########
@@ -193,6 +193,8 @@ private SqlTypeAssignmentRule(
rule.add(SqlTypeName.GEOMETRY);
rule.add(SqlTypeName.CHAR);
rule.add(SqlTypeName.VARCHAR);
+ rule.add(SqlTypeName.BINARY);
Review Comment:
I think some of these bug fixes have been addressed separately by Lucas
Brenner in CALCITE-7073. I had a few merge conflicts when rebasing the current
branch.
I'm not completely sure what else could be extracted into smaller PR/bug
fixes and would prefer to squash merge this PR to move on ;)
At this point I'm not completely sure what else could be extracted into
smaller PR/bug fixes. To keep things moving, I’d prefer to squash-merge, unless
anyone has other suggestions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
