xiedeyantu commented on code in PR #4565:
URL: https://github.com/apache/calcite/pull/4565#discussion_r2396385580
##########
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##########
@@ -12086,6 +12086,22 @@ void assertSubFunReturns(boolean binary, String s, int
start,
f0.forEachLibrary(libraries, consumer);
}
+ /** Test case for <a
href="https://issues.apache.org/jira/browse/CALCITE-7210";>[CALCITE-7210]
+ * BINARY literal values may not match their type</a>. */
+ @Test void testLeastBinary() {
+ final SqlOperatorFixture f = fixture()
+ .setFor(SqlLibraryOperators.LEAST, VmName.EXPAND)
+ .withLibrary(SqlLibrary.BIG_QUERY);
+ f.checkScalar("least(x'01', x'0202')", "0100", "BINARY(2) NOT NULL");
+
+ final SqlOperatorFixture f0 = fixture()
+ .setFor(SqlLibraryOperators.LEAST, VmName.EXPAND)
+ // for shouldConvertRaggedUnionTypes
Review Comment:
Does it need to be changed to shouldConvertRaggedUnionTypesToVarying?
##########
site/community/index.md:
##########
@@ -249,6 +249,7 @@ If you have something interesting to share with the
community drop us an email o
consider creating a pull request on GitHub. If you just finished a cool
project using Calcite
consider writing a short article about it for our [news section]({{
site.baseurl }}/news/index.html).
+* <a href="https://www.feldera.com/blog/constant-folding-in-calcite";>Constant
folding in Calcite</a> (Mihai Budiu, 2025)
Review Comment:
Excellent article!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
