snuyanzin commented on code in PR #4612:
URL: https://github.com/apache/calcite/pull/4612#discussion_r2484842684
##########
testkit/src/main/java/org/apache/calcite/test/DiffRepository.java:
##########
@@ -586,7 +586,7 @@ private synchronized void update(
int i = 0;
final List<String> names = Pair.left(map);
for (String s : names) {
- if (s.compareToIgnoreCase(testCaseName) <= 0) {
+ if (s.compareTo(testCaseName) <= 0) {
Review Comment:
as here lexicographical order with respect of case is used
https://github.com/apache/calcite/blob/67e5bfcdc0151aa1926fa369382d12fc672ca5bf/testkit/src/main/java/org/apache/calcite/test/DiffRepository.java#L643-L645
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
