xiedeyantu commented on PR #4620: URL: https://github.com/apache/calcite/pull/4620#issuecomment-3524311821
> For example, it's not clear whether the visitor method for LogicalSnapshot is supposed to call the visitor method for superclasses. Should the implementation of the visitor be set as final or private as much as possible? However, it seems that it is currently inheritable. If modifications are made to the existing visitor, would this have an impact on forward compatibility? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
