wForget commented on code in PR #4817:
URL: https://github.com/apache/calcite/pull/4817#discussion_r2875559783
##########
core/src/main/java/org/apache/calcite/sql/fun/SqlBetweenOperator.java:
##########
@@ -177,7 +177,9 @@ private static SqlBetweenOperator of(boolean negated,
boolean symmetric) {
writer.startList(FRAME_TYPE, "", "");
call.operand(VALUE_OPERAND).unparse(writer, getLeftPrec(), 0);
writer.sep(super.getName());
- writer.sep(flag.name());
+ if (writer.getDialect().supportsSQL99Between()) {
Review Comment:
Thank you for pointing that out — I missed that comment. It seems we're
doing this conversion in
`toRel`https://github.com/apache/calcite/blob/7654dd82162508231cb3ed44e60fed356e931403/core/src/main/java/org/apache/calcite/sql2rel/StandardConvertletTable.java#L1414.
Do we still need to do the same in unparse? Perhaps we could simply throw an
exception here for unsupported SYMMETRIC calls. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
