mihaibudiu commented on code in PR #4816:
URL: https://github.com/apache/calcite/pull/4816#discussion_r2881440770
##########
testkit/src/main/java/org/apache/calcite/sql/parser/SqlParserTest.java:
##########
@@ -1410,6 +1410,32 @@ private void checkLarge(int n) {
.ok("VALUES (ROW((`A` BETWEEN ASYMMETRIC ((`B` OR (`C` AND `D`)) OR
`E`) AND `F`)))");
}
+ @Test void testBetweenInverse() throws Exception {
Review Comment:
It's possible that whoever wrote this operator always envisioned it will
never appear in a Rel program, since it is removed by the convertlet table. I
actually think it's safe to also replace the body of
SqlBetweenOperator.validRexOperands to check that the number of operands is 2
(similar with SqlBinaryOperator).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
