xiedeyantu commented on code in PR #4803:
URL: https://github.com/apache/calcite/pull/4803#discussion_r2958398992
##########
core/src/main/java/org/apache/calcite/plan/hep/HepPlanner.java:
##########
@@ -136,11 +139,13 @@ public class HepPlanner extends AbstractRelOptPlanner {
*
* <p>Value: match-key ID lists in {@link #firedRulesCache} that contain the
key ID.
*/
- private final Multimap<Integer, List<Integer>> firedRulesCacheIndex =
HashMultimap.create();
-
+ private final Multimap<Integer, ImmutableIntList> firedRulesCacheIndex =
HashMultimap.create();
private boolean enableFiredRulesCache = false;
+ private boolean largePlanMode = false;
Review Comment:
I'm not very familiar with this optimization; I only took a quick look, but
it seems to be quite effective. I do have one concern, though: should we add a
specific test to verify the correctness of the execution plan? Alternatively,
could we simply remove the `largePlanMode` configuration entirely (or set it to
`true` for the purpose of comparative testing) and let all existing test cases
validate the plan's correctness?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
