zabetak commented on PR #4846: URL: https://github.com/apache/calcite/pull/4846#issuecomment-4132512864
FYI: We have a whole framework in place for testing rules based on `RelOptFixture` and `DiffRepository`. The test in this PR would be much shorter and easier to read if it was re-using existing code. Ideally, the test should be either moved to `RelOptRulesTest` class or follow the paradigm of `AggregateFilterToFilteredAggregateRuleTest`. @darpan-e6 If you have some time to rework the test raise a new PR and ping me for review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
