caicancai commented on code in PR #4843:
URL: https://github.com/apache/calcite/pull/4843#discussion_r2994978973
##########
arrow/src/main/java/org/apache/calcite/adapter/arrow/AbstractArrowEnumerator.java:
##########
@@ -66,16 +69,51 @@ protected void loadNextArrowBatch() {
@Override public Object current() {
if (fields.size() == 1) {
- return this.valueVectors.get(0).getObject(currRowIndex);
+ return getValue(this.valueVectors.get(0), currRowIndex);
}
Object[] current = new Object[valueVectors.size()];
for (int i = 0; i < valueVectors.size(); i++) {
ValueVector vector = this.valueVectors.get(i);
- current[i] = vector.getObject(currRowIndex);
+ current[i] = getValue(vector, currRowIndex);
}
return current;
}
+ /** Extracts a value from a vector at the given index.
+ *
+ * <p>For {@link TimeStampVector}, converts the raw value to
+ * milliseconds since epoch, which is Calcite's internal representation
Review Comment:
The description has been modified.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
