caicancai commented on code in PR #4848:
URL: https://github.com/apache/calcite/pull/4848#discussion_r3001197095
##########
arrow/src/main/java/org/apache/calcite/adapter/arrow/ArrowTable.java:
##########
@@ -184,6 +178,23 @@ private static RelDataType deduceRowType(Schema schema,
return builder.build();
}
+ private TreeNode parseSingleCondition(String condition) {
Review Comment:
I have now changed it to a structured token format instead of string
parsing:
- unary: [fieldName, operator]
- binary: [fieldName, operator, value, type]
So we no longer rely on splitting by spaces, and string literals like
'literal with space' are handled correctly. I also documented the token grammar
in the JavaDoc of
`parseSingleCondition` and added/updated tests for both spaced string
literals and empty-string literals.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
