mihaibudiu commented on code in PR #4869:
URL: https://github.com/apache/calcite/pull/4869#discussion_r3076454076
##########
core/src/main/java/org/apache/calcite/sql/validate/implicit/TypeCoercionImpl.java:
##########
@@ -688,6 +690,126 @@ private boolean coalesceCoercion(SqlCallBinding
callBinding) {
return coercedLeft || coercedRight;
}
+ @Override public boolean collectionFunctionCoercion(SqlCallBinding binding) {
+ final SqlCall call = binding.getCall();
+ switch (call.getKind()) {
+ case MAP_VALUE_CONSTRUCTOR:
Review Comment:
Type coercion cannot depend on various functions like ARRAY_APPEND.
##########
core/src/main/java/org/apache/calcite/sql/validate/implicit/TypeCoercion.java:
##########
@@ -200,6 +200,15 @@ boolean builtinFunctionCoercion(
List<RelDataType> operandTypes,
List<SqlTypeFamily> expectedFamilies);
+ /**
Review Comment:
Type coercion can depend on functions, it's the other way around: functions
can use some services from type coercion.
So I don't understand what this function means.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
