jogrogan commented on code in PR #4891:
URL: https://github.com/apache/calcite/pull/4891#discussion_r3102564200
##########
core/src/main/java/org/apache/calcite/jdbc/CalciteMetaImpl.java:
##########
@@ -543,9 +545,7 @@ public Enumerable<MetaColumn> columns(final MetaTable
table_) {
String catalog,
Pat schemaPattern,
Pat functionNamePattern) {
- final Predicate1<MetaSchema> schemaMatcher = namedMatcher(schemaPattern);
- return createResultSet(schemas(catalog)
- .where(schemaMatcher)
+ return createResultSet(schemas(catalog, new LikePattern(schemaPattern.s))
Review Comment:
LikePattern should be fully equivalent already. namedMatcher delegates to
`LikePattern.matcher(pattern.s)` internally. The only thing it added was
applying the resulting predicate to e.getName(). This is doing functionally the
same thing but pushing the pattern down into `.subSchemas().getNames(pattern)`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
