Dwrite commented on code in PR #4877:
URL: https://github.com/apache/calcite/pull/4877#discussion_r3138490656
##########
core/src/test/resources/org/apache/calcite/test/RelOptRulesTest.xml:
##########
@@ -1530,7 +1530,7 @@ LogicalProject(MGR=[$3])
<Resource name="planMid">
<![CDATA[
LogicalProject(DEPTNO=[$0], EXPR$1=[OR(AND(IS NOT NULL($5), <>($2, 0)),
AND(<($3, $2), null, <>($2, 0), IS NULL($5)))])
- LogicalJoin(condition=[=($1, $4)], joinType=[left])
+ LogicalJoin(condition=[=(CAST($1):INTEGER NOT NULL, $4)], joinType=[left])
Review Comment:
The NOT NULL in the CAST reflects the nullability of the original column
(name is defined as NOT NULL in the DEPT table), preserved by syncAttributes
inside coerceOperandType. This is consistent with how inOperationCoercion
handles the same case. Is this behavior acceptable, or should we always use
nullable in the CAST to be safe?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
