xuzifu666 commented on code in PR #4926:
URL: https://github.com/apache/calcite/pull/4926#discussion_r3208703816
##########
core/src/test/java/org/apache/calcite/test/SqlValidatorTest.java:
##########
@@ -8129,6 +8129,10 @@ void testGroupExpressionEquivalenceParams() {
.type("RecordType(INTEGER NOT NULL EXPR$0) NOT NULL");
s.withSql("select HIGHER_ORDER_FUNCTION2(1, () -> 0.1)")
.type("RecordType(INTEGER NOT NULL EXPR$0) NOT NULL");
+ s.withSql("select HIGHER_ORDER_FUNCTION(1, (x, y) -> x + 1 + ^emp.deptno^)
from emp")
Review Comment:
Please add jira message in test.
##########
core/src/main/java/org/apache/calcite/rex/RexBiVisitorImpl.java:
##########
@@ -120,7 +120,10 @@ protected RexBiVisitorImpl(boolean deep) {
}
@Override public R visitLambda(RexLambda lambda, P arg) {
- return null;
+ if (!deep) {
Review Comment:
I think you could add some comments here to explain the reason.
##########
core/src/test/resources/sql/lambda.iq:
##########
@@ -102,3 +102,15 @@ select "EXISTS"(array[array[1, 2], array[3, 4]], x -> x[1]
= 1);
(1 row)
!ok
+
+select *
Review Comment:
also here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
