mmoradi0101 commented on PR #4872: URL: https://github.com/apache/calcite/pull/4872#issuecomment-4427900921
> you should use new commits for changes until they are approved, and squash at that point Understood, I didn't realize the rebase was squashing my commits. From now on I'll only add new commits and squash after approval. Thanks for the clarification! The failing test testExtractValue() appears to be unrelated to this PR.. it fails with an XML well formedness error, not related to DECIMAL precision handling. Could this be a pre-existing flaky test? @mihaibudiu -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
