cjj2010 commented on code in PR #4926:
URL: https://github.com/apache/calcite/pull/4926#discussion_r3263489295
##########
core/src/main/java/org/apache/calcite/sql/validate/SqlLambdaScope.java:
##########
@@ -76,9 +74,13 @@ public boolean isParameter(SqlIdentifier id) {
}
@Override public @Nullable RelDataType resolveColumn(String columnName,
SqlNode ctx) {
- checkArgument(parameterTypes.containsKey(columnName),
- "column %s not found", columnName);
- return parameterTypes.get(columnName);
+ if (parameterTypes.containsKey(columnName)) {
Review Comment:
> Do you know what happens to case sensitivity? I suspect parameter names
are subject to the same rules as other identifiers, including quoting. Can you
please write some tests using uppercase/lowercase parameter names and also
using quoted names?
Thank you for reminding me that the support for case sensitivity here is
indeed not rigorous enough. I have made optimizations and added test cases. I
am very grateful for your professional and meticulous review of this pull
request (PR)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
