xuzifu666 commented on code in PR #4973:
URL: https://github.com/apache/calcite/pull/4973#discussion_r3318795421


##########
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java:
##########
@@ -1708,6 +1708,21 @@ private static String toSql(RelNode root, SqlDialect 
dialect,
         .ok(expectedOracle);
   }
 
+  /** Test case for
+   * <a 
href="https://issues.apache.org/jira/browse/CALCITE-7563";>[CALCITE-7563]
+   * Oracle dialect generates invalid CAST to VARCHAR without precision</a>. */
+  @Test void testCastVarcharWithoutPrecisionOracle() {

Review Comment:
   I assume you have already tested these sql in Oracle.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to