mihaibudiu commented on code in PR #4974:
URL: https://github.com/apache/calcite/pull/4974#discussion_r3319750558
##########
core/src/test/java/org/apache/calcite/test/MaterializedViewSubstitutionVisitorTest.java:
##########
@@ -112,6 +112,16 @@ protected final MaterializedViewFixture sql(String
materialize,
.ok();
}
+ /** Test case of
+ * <a
href="https://issues.apache.org/jira/browse/CALCITE-6823";>[CALCITE-6823]
+ * Cannot convert CHAR to Integer when applying SubstitutionVisitor</a>. */
+ @Test void testDateFilter() {
Review Comment:
What happens if the string is not a valid date literal?
You should get a decent error, not a crash.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
