snuyanzin commented on code in PR #4995:
URL: https://github.com/apache/calcite/pull/4995#discussion_r3363402337
##########
core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java:
##########
@@ -3642,9 +3642,10 @@ private RexNode convertUsing(SqlValidatorNamespace
leftNamespace,
offset += rowType.getFieldList().size();
}
- RelDataType resultType =
- validator().getTypeCoercion().commonTypeForBinaryComparison(
- comparedTypes.get(0), comparedTypes.get(1));
+ RelDataType resultType = validator.config().typeCoercionEnabled()
Review Comment:
yeah, checker framework is also unhappy about this
I replaced it with `validator()` method which has embedded null check,
should be fine now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
