mihaibudiu commented on code in PR #5003:
URL: https://github.com/apache/calcite/pull/5003#discussion_r3383023751
##########
core/src/main/java/org/apache/calcite/rel/rules/AggregateReduceFunctionsOnGroupKeysRule.java:
##########
@@ -183,6 +184,15 @@ protected AggregateReduceFunctionsOnGroupKeysRule(Config
config) {
((SqlConstantValueAggFunction) call.getAggregation())
.getConstantResult(rexBuilder, call.getType());
if (constantResult != null) {
+ // Handle NULL semantics: if the GROUP BY key is nullable and the
constant value
Review Comment:
The fact that you haven't caught this case suggests that you have to add at
least a couple of Quidem tests. They would catch this kind of problem much
faster than reading plans.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
