xuzifu666 commented on code in PR #5041:
URL: https://github.com/apache/calcite/pull/5041#discussion_r3459371150
##########
core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java:
##########
@@ -5972,7 +5972,7 @@ private void checkEmptyJoin(RelOptFixture f) {
@Test void testReduceCastsNullable() {
HepProgram program = new HepProgramBuilder()
- // Simulate the way INSERT will insert casts to the target types
+ // Simulate the way INSERT can insert casts to the target types.
Review Comment:
I don't understand why this comment needs to be changed.
##########
server/src/test/resources/sql/materialized_view.iq:
##########
@@ -19,7 +19,7 @@
!set outputformat mysql
# Create a source table
-create table dept (deptno int not null, name varchar(10));
+create table dept (deptno int not null, name varchar(20));
Review Comment:
Could you provide a specific SQL test and compare the results? You can add
relevant comments here.
##########
core/src/test/java/org/apache/calcite/test/JdbcTest.java:
##########
@@ -390,7 +390,7 @@ static void forEachExpand(Runnable r) {
+ "expr#7=[null:JavaType(class java.lang.Integer)], "
+ "empid=[$t3], deptno=[$t4], name=[$t5], salary=[$t6], "
+ "commission=[$t7])\n"
- + " EnumerableValues(tuples=[[{ 'Fred', 56,
123.4000015258789E0 }]])\n";
+ + " EnumerableValues(tuples=[[{ 'Fred', 56, 123.4 }]])\n";
Review Comment:
These variations in precision may also require an explanation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
