mihaibudiu commented on code in PR #5048:
URL: https://github.com/apache/calcite/pull/5048#discussion_r3470585630
##########
file/src/main/java/org/apache/calcite/adapter/file/CsvTableScan.java:
##########
@@ -53,23 +56,45 @@
*/
public class CsvTableScan extends TableScan implements EnumerableRel {
final CsvTranslatableTable csvTable;
- private final int[] fields;
+ final int[] fields;
+ final @Nullable String[] filterValues;
protected CsvTableScan(RelOptCluster cluster, RelOptTable table,
CsvTranslatableTable csvTable, int[] fields) {
+ this(cluster, table, csvTable, fields, null);
+ }
+
+ protected CsvTableScan(RelOptCluster cluster, RelOptTable table,
+ CsvTranslatableTable csvTable, int[] fields,
+ @Nullable String @Nullable [] filterValues) {
Review Comment:
I think CsvEnumerator is actually broken, since it does string comparisons.
This means for example that 0.0 != 0 in a filter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
