rubenada commented on code in PR #5070:
URL: https://github.com/apache/calcite/pull/5070#discussion_r3518297700
##########
core/src/main/java/org/apache/calcite/rex/RexSimplify.java:
##########
@@ -2126,6 +2126,13 @@ private <C extends Comparable<C>> RexNode
simplifyUsingPredicates(RexNode e,
} else if (rangeSet2.equals(RangeSets.rangeSetAll())) {
// Range is always satisfied given these predicates; but nullability
might
// be problematic
+ if (unknownAs != UNKNOWN) {
+ // If unknownAs FALSE: row is already excluded for null input, so the
IS_NOT_NULL
Review Comment:
added new test covering 3 cases
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]