xuzifu666 commented on code in PR #5101:
URL: https://github.com/apache/calcite/pull/5101#discussion_r3579665310
##########
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java:
##########
@@ -2016,6 +2016,27 @@ private static String toSql(RelNode root, SqlDialect
dialect,
relFn(relFn).withOracle().ok(expectedOracle);
}
+ /** Test case for
+ * <a
href="https://issues.apache.org/jira/browse/CALCITE-7655";>[CALCITE-7655]
+ * RelToSqlConverter incorrectly removes a subquery when grouping by a
window function
+ * result</a>. */
+ @Test void testGroupByWindowFunction() {
Review Comment:
As you described in Jira, the default generated SQL is not supported by many
databases; therefore, the tests here should include the appropriate dialect to
verify that the generated SQL is valid for the databases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
