Samin061 opened a new pull request, #5106: URL: https://github.com/apache/calcite/pull/5106
## Jira Link No Jira for this one yet. Happy to open a CALCITE issue if you want it tracked. ## Changes Proposed **Inverted identifier quoting in the Firebolt dialect** `identifierNeedsQuote` returns the regex match, while `ExasolSqlDialect` and `BigQuerySqlDialect`, which carry the same regex and the same javadoc, return its negation. Firebolt quotes the identifiers that are already safe unquoted, and emits the ones that are not (spaces, `$`, backticks, embedded quotes) raw, so an alias carrying a double quote leaves its identifier and the remainder is parsed as SQL rather than as a name. `testIdentifier` already pins this behaviour down for the other dialects, so I added Firebolt to it. Before the change that case gives `4 AS fo$ur` and ``6 AS si`x`` unquoted. The Firebolt expectations elsewhere in the test were written against the old output and now line up with Exasol, which is the behaviour the regex and the keyword list were there for. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
