mihaibudiu commented on code in PR #5104:
URL: https://github.com/apache/calcite/pull/5104#discussion_r3596873195
##########
core/src/test/java/org/apache/calcite/sql/type/SqlTypeFactoryTest.java:
##########
@@ -87,6 +87,42 @@ class SqlTypeFactoryTest {
assertThat(leastRestrictive.isNullable(), is(true));
}
+ /** UNKNOWN types in leastRestrictive() affect only the result nullability.
*/
+ @Test void testLeastRestrictiveWithUnknown() {
Review Comment:
There should be very good coverage for non-UNKNOWN types, and this PR only
reduces the case with UNKNOWN to the case without.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
