snuyanzin commented on code in PR #5107:
URL: https://github.com/apache/calcite/pull/5107#discussion_r3599422713
##########
testkit/src/main/java/org/apache/calcite/sql/parser/SqlParserTest.java:
##########
@@ -4989,24 +4989,27 @@ void checkPeriodPredicate(Checker checker) {
final String expected = "SELECT *\n"
+ "FROM TABLE(`TOPN`((TABLE `ORDERS`) ORDER BY `ORDERID`, 3))";
sql(sql).ok(expected);
+ sql(expected).withConfig(c -> c.withQuoting(Quoting.BACK_TICK)).same();
}
@Test void testTableFunctionWithMultipleOrderKeys() {
// test multiple order keys for input table
final String sql =
"select * from table(topn(table orders order by (orderId, productid),
3))";
final String expected = "SELECT *\n"
- + "FROM TABLE(`TOPN`((TABLE `ORDERS`) ORDER BY `ORDERID`, `PRODUCTID`,
3))";
+ + "FROM TABLE(`TOPN`((TABLE `ORDERS`) ORDER BY (`ORDERID`,
`PRODUCTID`), 3))";
Review Comment:
the expected sql here and in other places was invalid: parser just fails
while parsing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
