mihaibudiu commented on code in PR #5048:
URL: https://github.com/apache/calcite/pull/5048#discussion_r3599498772
##########
file/src/test/java/org/apache/calcite/adapter/file/FileAdapterTest.java:
##########
@@ -438,6 +602,53 @@ private static void checkEmpty(ResultSet resultSet) {
.ok();
}
+ @Test void testFilterPushDownOr() {
+ sql("smart", "select name from EMPS where deptno = 20 or empno = 100")
+ .returns("NAME=Fred", "NAME=Eric", "NAME=Wilma")
+ .ok();
+ }
+
Review Comment:
Why isn't this filter pushed down?
##########
file/src/test/java/org/apache/calcite/adapter/file/FileAdapterTest.java:
##########
@@ -438,6 +602,53 @@ private static void checkEmpty(ResultSet resultSet) {
.ok();
}
+ @Test void testFilterPushDownOr() {
+ sql("smart", "select name from EMPS where deptno = 20 or empno = 100")
+ .returns("NAME=Fred", "NAME=Eric", "NAME=Wilma")
+ .ok();
+ }
+
+ @Test void testFilterPushDownOrPlan() {
Review Comment:
If you have two tests like this which test the same query please put them in
the same function and reuse the SQL as a string. This will make it clearer that
they are testing the same query from different points of view.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
