mihaibudiu commented on code in PR #5144:
URL: https://github.com/apache/calcite/pull/5144#discussion_r3714851801
##########
core/src/main/java/org/apache/calcite/interpreter/AggregateNode.java:
##########
@@ -136,6 +137,8 @@ private AccumulatorFactory getAccumulator(Compiler compiler,
final Class<?> clazz = maxMinClass(call);
return new UdaAccumulatorFactory(getAggFunction(clazz), call, true,
dataContext);
+ } else if (op == SqlStdOperatorTable.SINGLE_VALUE) {
Review Comment:
I am not sure how this is related to the issue being solved.
Maybe these fixes should be in the scope of a separate JIRA issue.
##########
core/src/main/java/org/apache/calcite/interpreter/Nodes.java:
##########
@@ -46,8 +46,9 @@ public class Nodes {
* that knows how to handle the core logical
* {@link org.apache.calcite.rel.RelNode}s. */
public static class CoreCompiler extends Interpreter.CompilerImpl {
- CoreCompiler(@UnknownInitialization Interpreter interpreter, RelOptCluster
cluster) {
- super(interpreter, cluster);
+ CoreCompiler(@UnknownInitialization Interpreter interpreter,
Review Comment:
I am not sure you can change public APIs, that would be a violation of
semantic versioning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
