sbroeder commented on code in PR #5187:
URL: https://github.com/apache/calcite/pull/5187#discussion_r3804934815
##########
core/src/test/java/org/apache/calcite/test/SqlValidatorTest.java:
##########
@@ -1043,6 +1025,30 @@ void testDyadicCollateOperator() {
.fails("Parameters must be of the same type");
}
+ /** Test case for <a
href="https://issues.apache.org/jira/browse/CALCITE-7724";>
+ * [CALCITE-7724] SqlUtil#lookupSubjectRoutines rejects a valid operator
when its
+ * SqlKind is remapped by SqlKind#getFunctionKind() and two operator-table
entries
+ * resolve to it</a>.
+ *
+ * <p>The kind-based fourth pass in {@code filterOperatorRoutinesByKind}
maps only
Review Comment:
I've tried to keep it short and be clear. Two competing goals. Are you
okay with the comments as they are or do you have a preferred change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
