xuzifu666 commented on code in PR #5188:
URL: https://github.com/apache/calcite/pull/5188#discussion_r3810476198
##########
core/src/test/java/org/apache/calcite/test/JdbcTest.java:
##########
@@ -9695,6 +9695,24 @@ void checkCalciteSchemaGetSubSchemaMap(boolean cache) {
}
}
+ /** Test case for
+ * <a
href="https://issues.apache.org/jira/browse/CALCITE-6284";>[CALCITE-6284]
+ * Invalid conversion triggers ClassCastException</a>. */
+ @Test void bindStringParameter() {
Review Comment:
Thanks for pointing that out. The original test only covered the success
path. I added bindInvalidStringParameter() and improved the error message:
Before: NumberFormatException with null message.
After: NumberFormatException: Invalid value for BigDecimal: "abc".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
