mihaibudiu commented on code in PR #5192:
URL: https://github.com/apache/calcite/pull/5192#discussion_r3815450388
##########
linq4j/src/main/java/org/apache/calcite/linq4j/tree/Expressions.java:
##########
@@ -3290,6 +3304,56 @@ public interface FluentList<T> extends List<T> {
FluentList<T> appendAll(T... ts);
}
+ /** Visitor that detects whether a node may cause a runtime error.
+ *
+ * <p>The analysis is deliberately cheap and conservative. Any method call or
+ * constructor may throw; so may division, remainder and checked arithmetic.
+ * Everything else - reading a variable, a field or an array element, and
Review Comment:
After a complete audit of all operations that can throw, this visitor will
become more complicated, but hopefully safe. I will submit a new commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
